Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] [Refactor] Empty state for db table #845

Merged
merged 13 commits into from
Nov 25, 2024
Merged

[UI] [Refactor] Empty state for db table #845

merged 13 commits into from
Nov 25, 2024

Conversation

dianabirs
Copy link
Contributor

@dianabirs dianabirs commented Nov 19, 2024 •
edited
Loading

@dianabirs dianabirs requested a review from a team as a code owner November 19, 2024 09:42
@dianabirs dianabirs requested a review from a team November 25, 2024 09:39
@fabio-silva fabio-silva self-requested a review November 25, 2024 10:40
solovevayaroslavna
solovevayaroslavna requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@solovevayaroslavna solovevayaroslavna left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things

ui/packages/ui-lib/src/icons/index.ts Show resolved Hide resolved
ui/apps/everest/src/pages/databases/emptyState/emptyState.tsx Outdated Show resolved Hide resolved
ui/packages/ui-lib/src/table/table.tsx Outdated Show resolved Hide resolved
@dianabirs dianabirs merged commit 615beb7 into main Nov 25, 2024
8 checks passed
@dianabirs dianabirs deleted the EVEREST-1458-ui-refactor-empty-states-tables branch November 25, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solovevayaroslavna solovevayaroslavna solovevayaroslavna approved these changes

@fabio-silva fabio-silva fabio-silva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dianabirs @fabio-silva @solovevayaroslavna @mayankshah1607